Skip to content

fix: Email Banner design QA part 2#850

Merged
curlyfriesplease merged 4 commits intomasterfrom
ENG-4433-part-2
Mar 5, 2026
Merged

fix: Email Banner design QA part 2#850
curlyfriesplease merged 4 commits intomasterfrom
ENG-4433-part-2

Conversation

@curlyfriesplease
Copy link
Contributor

@curlyfriesplease curlyfriesplease commented Mar 5, 2026

PR description

What is it doing?

Couple of things from the last fix PR that hadn't quite worked as expected:

  1. The H1 text wasn't quite in the right style, owing to a line needing removing that specified a 'BIG' style
  2. The privacy copy's small text styling was getting overridden by the WYSIWYG styles. And as it turns out that rich text editor doesn't offer the exact text size we want, the solution is to override it by targeting its descendants.

Why is this required?

Website redesign project QA

link to Jira ticket:

ENG-4433

Quick Checklist:

  • My PR title follows the Conventional Commit spec.

  • I have filled out the PR description as per the template above.

  • I have added tests to cover new or changed behaviour.

  • I have updated any relevant documentation.

Important! - lastly, make sure to squash merge...

@curlyfriesplease curlyfriesplease changed the title ENG-4433-part-2 fix: Email Banner design QA part 2 Mar 5, 2026
@curlyfriesplease curlyfriesplease marked this pull request as ready for review March 5, 2026 12:54
@curlyfriesplease curlyfriesplease self-assigned this Mar 5, 2026
@curlyfriesplease curlyfriesplease merged commit 2c1f625 into master Mar 5, 2026
9 checks passed
@curlyfriesplease curlyfriesplease deleted the ENG-4433-part-2 branch March 5, 2026 15:01
@github-actions
Copy link

github-actions bot commented Mar 5, 2026

🎉 This PR is included in version 8.62.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants