Skip to content

fix: Email Banner design QA part 2 #850

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
curlyfriesplease merged 4 commits into from
Mar 5, 2026
Merged

fix: Email Banner design QA part 2 #850

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
f062318
ENG-4855 privacy text to be 12px
curlyfriesplease Mar 5, 2026
a725a38
ENG-4859 remove erroneous H1 styling
curlyfriesplease Mar 5, 2026
cb33ff9
Snapshots
curlyfriesplease Mar 5, 2026
5efa070
Merge branch 'master' into ENG-4433-part-2
curlyfriesplease Mar 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion src/components/Organisms/EmailBanner/EmailBanner.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,6 @@ const EmailBanner = ({
{title && (
<Text
tag="h1"
size="big"
family="Anton"
weight="normal"
>
Expand Down
10 changes: 10 additions & 0 deletions src/components/Organisms/EmailBanner/EmailBanner.style.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,16 @@ const PrivacyCopyWrapper = styled.div`
font-size: ${({ theme }) => theme.fontSize('xs')};
line-height: normal;
padding-bottom: ${spacing('sm')};

/* Forces the descendants to inherit the same font size and line height here,
because contentful's WYSIWYG editor doesn't offer the particular text
styles we want here */
& p,
& span,
& * {
font-size: inherit;
line-height: inherit;
}
`;

const SuccessCopyWrapper = styled.div`
Expand Down
28 changes: 28 additions & 0 deletions src/components/Organisms/EmailBanner/__snapshots__/EmailBanner.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -330,6 +330,13 @@ exports[`Image banner left orientation renders correctly 1`] = `
padding-bottom: 0.5rem;
}

.c19 p,
.c19 span,
.c19 * {
font-size: inherit;
line-height: inherit;
}

.c20 {
margin-top: 1rem;
}
Expand Down Expand Up @@ -1063,6 +1070,13 @@ exports[`Image banner renders correctly 1`] = `
padding-bottom: 0.5rem;
}

.c19 p,
.c19 span,
.c19 * {
font-size: inherit;
line-height: inherit;
}

.c20 {
margin-top: 1rem;
}
Expand Down Expand Up @@ -1796,6 +1810,13 @@ exports[`Text-only email widget renders correctly 1`] = `
padding-bottom: 0.5rem;
}

.c19 p,
.c19 span,
.c19 * {
font-size: inherit;
line-height: inherit;
}

.c20 {
margin-top: 1rem;
}
Expand Down Expand Up @@ -2529,6 +2550,13 @@ exports[`Text-only email widget with copyColor renders correctly 1`] = `
padding-bottom: 0.5rem;
}

.c19 p,
.c19 span,
.c19 * {
font-size: inherit;
line-height: inherit;
}

.c20 {
margin-top: 1rem;
}
Expand Down