Draft
Conversation
|
|
✅ E2E tests — success |
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a Firefox-specific rendering artifact where the background tint of collapsed Categorical Bins flashes as a square during scale/layout animations by introducing circular clipping on the bin element.
Changes:
- Add
clipPath: 'circle(50%)'to the collapsed Categorical Bin item styling to keep the fill clipped to a circle during animation.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
❌ E2E tests — failure |
|
✅ E2E tests — success |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Firefox, Categorical Bins flashed a square shaped tint behind the circle during scale animations. The fill now uses clip path so that the fill stays inside the circle during animation.
Example:
Can be reproduced by opening the Categorical Bin storybook on Firefox.