Skip to content

Fix: Firefox Categorical Bin Animation Flash #720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
buckhalt wants to merge 2 commits into from
+26 −19
Closed

Fix: Firefox Categorical Bin Animation Flash #720

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
757b75e
fix(categorical-bin): clip fill with clip-path to avoid Firefox bg leak
buckhalt Apr 22, 2026
134dd71
fix(categorical-bin): move clip path to inner wrapper so hover glow s…
buckhalt Apr 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
45 changes: 26 additions & 19 deletions lib/interviewer/Interfaces/CategoricalBin/components/CategoricalBinItem.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -160,16 +160,18 @@ const CategoricalBinItem = (props: CategoricalBinItemProps) => {
}

const circleClasses = cx(
'focusable flex min-w-0 cursor-pointer flex-col items-center justify-center overflow-hidden text-center outline-(--cat-color)',
'border-4 p-4',
'border-(--cat-color)',
catColor && 'bg-[oklch(from_var(--cat-color)_l_c_h/0.1)]',
!catColor && 'bg-surface',
'focusable flex min-w-0 cursor-pointer items-center justify-center text-center outline-(--cat-color)',
isOver &&
willAccept &&
'scale-110 shadow-[0_0_24px_var(--cat-color)] ring-4 ring-(--cat-color)',
);

const circleContentClasses = cx(
'flex size-full flex-col items-center justify-center border-4 border-(--cat-color) p-4 text-center',
catColor && 'bg-[oklch(from_var(--cat-color)_l_c_h/0.1)]',
!catColor && 'bg-surface',
);

return (
<motion.div
ref={mergedRef}
Expand All @@ -194,20 +196,25 @@ const CategoricalBinItem = (props: CategoricalBinItemProps) => {
transition={springTransition}
variants={binItemVariants}
>
<Heading level="h4">
<RenderMarkdown>{label}</RenderMarkdown>
</Heading>
<AnimatePresence>
{nodes.length > 0 && (
<motion.div
initial={{ opacity: 0 }}
animate={{ opacity: 1 }}
exit={{ opacity: 0 }}
>
<BinSummary nodes={nodes} />
</motion.div>
)}
</AnimatePresence>
<div
className={circleContentClasses}
style={{ borderRadius: '50%', clipPath: 'circle(50%)' }}
>
<Heading level="h4">
<RenderMarkdown>{label}</RenderMarkdown>
</Heading>
<AnimatePresence>
{nodes.length > 0 && (
<motion.div
initial={{ opacity: 0 }}
animate={{ opacity: 1 }}
exit={{ opacity: 0 }}
>
<BinSummary nodes={nodes} />
</motion.div>
)}
</AnimatePresence>
</div>
</motion.div>
);
};
Expand Down
Loading