refactor(codegen): replace string concatenation with Babel AST generation #611
+11,864
−8,891
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tion - Add babel-ast.ts helper file with reusable AST builders for: - Export const declarations with object literals - Object properties with string/array/function values - Arrow function expressions with parameters - TSAsExpression for 'as const' - Type aliases and imports - Block statements with conditionals - JSDoc and line comments using Babel's comment system - Rewrite query-keys.ts using pure Babel AST (@babel/types + @babel/generator) - Rewrite mutation-keys.ts using pure Babel AST - Rewrite invalidation.ts using pure Babel AST - Add @babel/generator, @babel/types, @types/babel__generator dependencies - Update snapshots to match Babel generator output All code generation now uses AST nodes instead of string concatenation. Prettier formatting is applied at file-write time in the CLI pipeline.
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…arrel to pure Babel AST - Remove unnecessary helper abstractions from babel-ast.ts - Use raw t.* calls instead of wrapper functions - Convert barrel.ts from string concatenation to Babel AST - Fix if statement formatting to use block statements - All 102 tests pass
- Rewrite queries.ts with pure Babel AST (replace ts-morph) - Rewrite mutations.ts with pure Babel AST (replace ts-morph) - Rewrite custom-queries.ts with pure Babel AST (replace ts-morph) - Rewrite custom-mutations.ts with pure Babel AST (replace ts-morph) - Rewrite schema-types-generator.ts with pure Babel AST - Update type-resolver.ts to remove ts-ast dependency (keep ts-ast.ts for ORM generators) All 102 tests pass, all 23 snapshots pass.
…generators Add 33 new snapshot tests covering: - Query hooks (list/single) with/without centralized keys - Mutation hooks (create/update/delete) with/without centralized keys - Custom query hooks with/without arguments - Custom mutation hooks with various argument types - Schema types generator - Barrel file generators (queries, mutations, main, custom)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Replaces string concatenation (
lines.push(),props.push()) and ts-morph usage with pure Babel AST generation using@babel/typesand@babel/generatoracross all React Query hook generators.Files Converted to Babel AST
query-keys.tsmutation-keys.tsinvalidation.tsqueries.tsmutations.tscustom-queries.tscustom-mutations.tsschema-types-generator.tsbarrel.tsA new
babel-ast.tshelper file provides reusable AST builders for common patterns (JSDoc comments, etc.).Note: The
ts-morphdependency andts-ast.tsfile remain because ORM generators (orm/directory) still use them. This PR only migrates the React Query codegen files.Updates Since Last Revision
Added comprehensive snapshot tests for all React Query hook generators:
Review & Testing Checklist for Human
react-query-hooks.test.ts.snapto ensure the semantic output is correctRecommended Test Plan
pnpm buildingraphql/codegento verify compilationpnpm testto verify all 135 tests passNotes
commentBlock,commentLine) are used for JSDoc commentsreact-query-hooks.test.tsvalidates generated output for all hook typesLink to Devin run: https://app.devin.ai/sessions/4d5df52ad251452da815b8cb06618596
Requested by: Dan Lynch (@pyramation)