Conversation
| require 'webmock/rspec' | ||
|
|
||
| # Require everything in the `support` directory | ||
| Dir[File.join(File.dirname(__FILE__), 'support', '**', '*.rb')].sort.each { |f| require f } |
There was a problem hiding this comment.
Aha, it looks like we originally did the sort because of https://docs.rubocop.org/rubocop/cops_lint.html#lintnondeterministicrequireorder, but that's no longer relevant with ruby 3+
| Enabled: false | ||
| Style/Documentation: | ||
| Enabled: false | ||
| Style/HashAsLastArrayItem: |
There was a problem hiding this comment.
The CI server has a cached version of rubocop that treats this rule differently depending on the ruby version. That's why this is added.
There was a problem hiding this comment.
Sorry, I don't understand. What is it that the CI server does if we don't disable this rule?
lavaturtle
left a comment
lavaturtle
left a comment
There was a problem hiding this comment.
Are we dropping support for ruby < 4.0, or are we aiming to support both 3.x and 4.0?
If the former, this should be a major version bump, since it's a breaking change.
If the latter, we should have the Github CI run the tests against all supported ruby versions.
2 participants
Upgraded Ruby to 4.0.1 and faraday to 2.14, addressing the breaking changes for the upgrades as well.