-
Notifications
You must be signed in to change notification settings - Fork 4
884: Ruby upgrade #29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
b08b98f
68acb1c
d6f1ce0
4004bf1
73d3288
b6e54c9
a3bf75d
0dc828a
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1 +1 @@ | ||
| 3.2.2 | ||
| 4.0.1 |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| # Changelog | ||
|
|
||
| ## [1.1.0] - 2026-02-11 | ||
|
|
||
| ### Added | ||
| - Added `faraday ~> 2.0` as explicit runtime dependency | ||
| - Added `faraday-mashify ~> 1.0` as explicit runtime dependency | ||
| - Added `require 'faraday/mashify'` to main library file | ||
|
|
||
| ### Upgrades | ||
| - Upgraded from Ruby 3.2.2 to Ruby 4.0.1 | ||
| - Updated vertebrae dependency to >= 1.0.5 | ||
| - Updated bundler development dependency to >= 2.1 (from ~> 2.1) |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| # frozen_string_literal: true | ||
|
|
||
| module ActionNetworkRest | ||
| VERSION = '1.0.1' | ||
| VERSION = '1.1.0' | ||
| end |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -5,7 +5,7 @@ | |
| require 'webmock/rspec' | ||
|
|
||
| # Require everything in the `support` directory | ||
| Dir[File.join(File.dirname(__FILE__), 'support', '**', '*.rb')].sort.each { |f| require f } | ||
|
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. no need to sort here IMO
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Aha, it looks like we originally did the sort because of https://docs.rubocop.org/rubocop/cops_lint.html#lintnondeterministicrequireorder, but that's no longer relevant with ruby 3+ |
||
| Dir[File.join(File.dirname(__FILE__), 'support', '**', '*.rb')].each { |f| require f } | ||
|
|
||
| RSpec.configure do |config| | ||
| # Enable flags like --only-failures and --next-failure | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The CI server has a cached version of rubocop that treats this rule differently depending on the ruby version. That's why this is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't understand. What is it that the CI server does if we don't disable this rule?