add pip-compile and hash support for security/reproducibility#496
Merged
stepansnigirev merged 2 commits intocryptoadvance:masterfrom Oct 11, 2020
Merged
add pip-compile and hash support for security/reproducibility#496stepansnigirev merged 2 commits intocryptoadvance:masterfrom
stepansnigirev merged 2 commits intocryptoadvance:masterfrom
Conversation
Contributor
Author
|
Foiled by my own |
Contributor
Author
|
Black is now fixed in #497 Once that is merged this should pass. |
Contributor
Author
|
Black passes again, this is ready to merge! (Don't know how to get TravisCI to run) |
Contributor
|
Thank you very much! This is really awesome PR. I didn't knew that this is possible and also haven't understood all implications but this is definitely very usefull. I tested the branch and the pip-installation worked. So this LGTM, i'd merge. |
Contributor
|
Looks good to me! |
stepansnigirev
approved these changes
Oct 11, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm running into a strange bug in #476, and I suspect that broken versioning is at play (though I'm not certain) so I decided to add this to specter, especially since it is very good for security. Read more about
--require-hasheshere.I updated the steps for pip to first install from
requirements.txtand then secondinstall -e .as this seems to be the best practice for validating those hashes on build (kind of hackey).