Conversation
jschneider-bensch
added
the
waiting-on-author
franziskuskiefer
force-pushed
the
franziskus/main-crate
branch
from
f0e02a3 to
07017d8
Compare
franziskuskiefer
force-pushed
the
franziskus/main-crate
branch
from
07017d8 to
141bf6b
Compare
|
I fixed the benchmarks and removed the specs workflow. I'm unsure if we want to release this main crate soon as well, or just keep it for internal consistency and mark the released version unmaintained until e.g. we decide we want to turn it around and make the sub-crates export from the main crate. |
keks
left a comment
keks
left a comment
There was a problem hiding this comment.
I think this looks good, just two minor questions
| @@ -0,0 +1 @@ | |||
| pub use hpke_rs::*; | |||
There was a problem hiding this comment.
does that mean we don't hardcode our provider?
There was a problem hiding this comment.
Doesn't the feature selection on hpke-rs do that?
There was a problem hiding this comment.
is this supposed to be still here?
There was a problem hiding this comment.
Are you asking if it should stay or not? I don't have it in the tree on this branch.
3 participants
Draft PR for discussion of cleaned up libcrux crate.
Open todos
cc @keks @jschneider-bensch
[skip changelog]