Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains fixes to the accessibility of expose. There is now an 'Expose content' button at the bottom of each panel and content is read out by the screen reader when it is exposed.
This has been tested with the NVDA screen reader on Chrome, Firefox & IE11.
We are aware of one minor issue: While previewing a course in firefox and IE11 the screen reader will continuously read out the alt text of the last card on the page.
I am not sure where the best place is to put the 'Expose content' button text in the properties.schema. If you could please advise I will get this updated.
I am aware that currently, if the user does not specify an item title it is displayed as "?", which is not read out by screen readers. I'm not sure whether it would be sufficient to say this should be specified in order to make the course accessible or whether this needs an aria-label?