Skip to content

Accessibility changes #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
canstudios-nicolaw wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Accessibility changes #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd976ca
Make expose completable with a screen reader
canstudios-nicolaw Apr 3, 2019
d796159
Fix indentation
canstudios-nicolaw Apr 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion js/adapt-expose.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,8 @@ define(function(require) {
events: {
"click .expose-item-cover": "toggleItem",
"click .expose-item-content": "toggleItem",
"click .expose-item-button": "toggleItem"
"click .expose-item-button": "toggleItem",
"click .expose-item-button-screen-reader": "toggleItem"
},

onDeviceResize: function() {
Expand Down Expand Up @@ -73,6 +74,8 @@ define(function(require) {
var i = $cover.parents(".expose-item").index();
this.model.get("_items")[i]._isVisited = true;
this.evaluateCompletion();
// Add the content to the aria-live field, remove content's aria-hidden property
$parent.children(".expose-item-content-screen-reader").prepend($parent.children(".expose-item-content").clone().attr('aria-hidden', false));
}
},

Expand Down
9 changes: 9 additions & 0 deletions less/expose.less
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,6 +121,15 @@
.zoom(0);
}
}

.screen-reader-only {
position:absolute;
left:-10000px;
top:auto;
width:1px;
height:1px;
overflow:hidden;
}
}

.expose-item-button {
Expand Down
6 changes: 4 additions & 2 deletions templates/expose.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,19 +5,21 @@
{{#each _items}}
<div class="expose-item nth-child-{{@index}}">
<div class="expose-item-inner">
<button class="expose-item-button"></button>
<button class="expose-item-button" aria-hidden="true"></button>
<div class="expose-item-cover">
<div class="back"></div>
<div class="front"></div>
<span class="text">{{#if front}} {{{a11y_text front}}} {{else}} ? {{/if}}</span>
</div>
<div class="expose-item-content">
<button class="screen-reader-only expose-item-button-screen-reader" aria-label="Expose button"></button>
<div class="expose-item-content" aria-hidden="true">
{{#with back}}
{{#if title}}<div class="expose-item-title">{{{a11y_text title}}}</div>{{/if}}
{{#if body}}<div class="expose-item-body">{{{a11y_text body}}}</div>{{/if}}
{{#if _graphic}}<img class="expose-item-img" src="{{_graphic.src}}" alt="{{_graphic.alt}}">{{/if}}
{{/with}}
</div>
<div class="screen-reader-only expose-item-content-screen-reader" aria-live="polite" aria-atomic="true"></div>
</div>
</div>
{{/each}}
Expand Down