Migrate from TinyMCE to QuillJS editor #1343
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1343 +/- ##
=======================================
Coverage 80.05% 80.05%
=======================================
Files 70 70
Lines 4729 4729
=======================================
Hits 3786 3786
Misses 943 943 🚀 New features to boost your workflow:
|
BenjaminCharmes
force-pushed
the
bc/migrate-to-quillJS
branch
2 times, most recently
from
b0dadd9 to
c4a1593
Compare
datalab
|
||||||||||||||||||||||||||||
| Project |
datalab
|
| Branch Review |
bc/migrate-to-quillJS
|
| Run status |
|
| Run duration | 06m 50s |
| Commit |
|
| Committer | Ben Charmes |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
168
|
| View all changes introduced in this branch ↗︎ | |
BenjaminCharmes
force-pushed
the
bc/migrate-to-quillJS
branch
4 times, most recently
from
b5f542b to
2ae6fe2
Compare
Add QuillJS to package.json Add QuillJS to package.json Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress Add data-testid to EditorTransition.vue for cypress
BenjaminCharmes
force-pushed
the
bc/migrate-to-quillJS
branch
from
2ae6fe2 to
d0fc4e3
Compare
|
If you haven't already, can you look a little into how custom tags would be handled in Quill? We would like to be able to type @ and select another item to link to. The editor would then insert in the colored badge according to item type. Ideally this would even be handled by just inserting the vue component, but inserting a vue component into the editor's environment may or may not be possible (I think this was very hard when I tried to do it in TinyMCE). These tags don't have to be implemented in this PR, but it would be good to make sure we have a path towards getting the tags in QuillJS |
|
Thanks for the feedback @jdbocarsly. We've already discussed this feature with @ml-evs and it's planned for a follow-up PR. I already intentionally removed Mermaid support from this PR to focus on testing Quill and basic Markdown support first, ensuring the TinyMCE migration works smoothly before adding more complex features. Cross-referencing with @ tags (as mentioned in issue #1232) is definitely on our roadmap. I'll take a quick look at how Quill handles custom tags and components to make sure we have a viable path forward. I can also try other editors if necessary; it's really quick to set up. I've seen that TipTap seems to be used quite a lot in vue3 projects. I will get back to you as soon as I have any news! |
Closes #1232
Migrates from TinyMCE to QuillJS.
Supports all previous features and adds support for markdowns.
Add component for backward compatibility with existing TinyMCE, will be removed in the future with either:
It seems that for the moment the only issue is with TinyMCE tables.
Support for Mermaids #1345 and cross-referencing will be added in future PRs.