Skip to content

add missing run params#286

Merged
yarikoptic merged 4 commits intodatalad:masterfrom
bpinsard:fix/add_missing_run_params
Mar 8, 2026
Merged

add missing run params#286
yarikoptic merged 4 commits intodatalad:masterfrom
bpinsard:fix/add_missing_run_params

Conversation

@bpinsard
Copy link
Copy Markdown
Contributor

--dry-run --assume-ready and --jobs params were not used even if imported from the Run command.

@codecov
Copy link
Copy Markdown

codecov bot commented Dec 16, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.95%. Comparing base (db11473) to head (af674af).
⚠️ Report is 5 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #286      +/-   ##
==========================================
+ Coverage   93.88%   93.95%   +0.07%     
==========================================
  Files          24       24              
  Lines        1112     1125      +13     
==========================================
+ Hits         1044     1057      +13     
  Misses         68       68              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@yarikoptic
Copy link
Copy Markdown
Member

yikes, nice, thank you @bpinsard ! I will push a rudimentary test to make sure it is all kosher

@bpinsard
Copy link
Copy Markdown
Contributor Author

bpinsard commented Mar 7, 2026

ready to merge?

Verifies that dry_run prevents command execution and that
assume_ready and jobs parameters are properly passed through.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@bpinsard bpinsard force-pushed the fix/add_missing_run_params branch from d40faad to a5daf8e Compare March 7, 2026 20:42
@yarikoptic yarikoptic added patch Increment the patch version when merged CHANGELOG-missing labels Mar 7, 2026
@yarikoptic yarikoptic merged commit c541894 into datalad:master Mar 8, 2026
7 checks passed
@bpinsard bpinsard deleted the fix/add_missing_run_params branch March 12, 2026 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

patch Increment the patch version when merged

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants