Fix Wi-Fi network configuration in settings server and improve UI #103
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbieber
force-pushed
the
claude-20250414-175550
branch
2 times, most recently
from
29b34a7 to
d7fd49c
Compare
The settings UI was correctly updating Wi-Fi networks in Redis, but not properly calling wifi.save_networks() which ensures proper handling before updating wpa_supplicant configuration. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
dbieber
force-pushed
the
claude-20250414-175550
branch
from
d7fd49c to
7d56aec
Compare
- Remove debug code from server.py - Fix Wi-Fi network save process by using proper wifi.save_networks() function - Add unsaved changes indicator to Save button in settings UI - Disable Save button when there are no changes to save
dbieber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
When I add a new wifi network in the settings UI, the wpa supplicant doesn't seem to be getting updated; is settings.set the right call? or should we be using wifi.save_networks()?
🤖 Generated with Claude Code