Optimize settings save by only sending changed values from the client #104
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Compare WiFi networks before running reconfigure_wifi - Skip saving other settings that haven't changed - Add diagnostic logs to track when settings are changed 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Compare each setting with its original value in the client - Only include changed settings in the request payload - Keep server-side processing unchanged 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This reverts commit 10103d6.
dbieber
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
When I click save in the settings UI, the raspberry pi freezes up for several seconds; one hypothesis I had is that its the call to reconfigure_wifi that causes things to hang. lets test this hypothesis by skipping saving any unchanged settings (thereby skipping reconfigure_wifi if the wifi list hasn't changed) so we can see if the hanging happens when I don't change the wifi list and just change a different setting; also, if you have other theories as to what's causing the hanging, let me know
🤖 Generated with Claude Code