Skip to content

Optimize settings save by only sending changed values from the client #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dbieber merged 3 commits into from
Apr 14, 2025
Merged

Optimize settings save by only sending changed values from the client #104

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
10103d6
Optimize settings save by skipping unchanged values
dbieber Apr 14, 2025
0b15203
Modify settings UI to only send changed values to server
dbieber Apr 14, 2025
f8cc900
Revert "Optimize settings save by skipping unchanged values"
dbieber Apr 14, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 18 additions & 1 deletion gonotego/settings-server/src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,12 +143,29 @@ const SettingsUI = () => {
const handleSave = async () => {
setSaveStatus('saving');
try {
// Create an object with only the changed settings
const changedSettings = {};

// Compare each setting with its original value
for (const [key, value] of Object.entries(settings)) {
// Get the original value
const originalValue = originalSettings[key];

// Check if this setting has changed using string comparison
// This handles all types of settings including arrays (via JSON.stringify)
if (JSON.stringify(value) !== JSON.stringify(originalValue)) {
changedSettings[key] = value;
}
}

console.log('Sending only changed settings:', changedSettings);

const response = await fetch('/api/settings', {
method: 'POST',
headers: {
'Content-Type': 'application/json',
},
body: JSON.stringify(settings),
body: JSON.stringify(changedSettings),
});

if (!response.ok) {
Expand Down