Replace usages of http with excon

[yeikel]

What are you trying to accomplish?

Removed the dependency on the http library and unified the http calls behind excon

Closes #10881

Anything you want to highlight for special attention from reviewers?

Sorbet needed a Shim which I documented in the code

How will you know you've accomplished your goal?

• We no longer need http library as a dependency
• The existing test pass

Checklist

• I have run the complete test suite to ensure all tests and linters pass.
• I have thoroughly tested my code changes to ensure they work as expected, including adding additional tests for new functionality.
• I have written clear and descriptive commit messages.
• I have provided a detailed description of the changes in the pull request, including the problem it addresses, how it fixes the problem, and any relevant details about the implementation.
• I have ensured that the code is well-documented and easy to understand.

[yeikel]

@JamieMagee Any chance you can review this?

[markhallen]

@yeikel This seems ok, but before i approve, did you try regenerating the webmock gem rbi?

[yeikel]

@markhallen Thank you for the feedback and suggestion.

I did try that, but that did not seem to work

Steps to reproduce:

   rm sorbet/rbi/shims/http_base64.rbi
  bundle exec tapioca gems webmock

rbenv exec bundle exec tapioca gems webmock
Requiring all gems to prepare for compiling...  Done

Removing RBI files of gems that have been removed:

  Nothing to do.


  Compiled webmock
       force  sorbet/rbi/gems/webmock@3.25.1.rbi

Checking generated RBI files...  Done
  No errors found

All operations performed in working directory.

See:

79ef241

https://github.com/dependabot/dependabot-core/actions/runs/21155220687/job/60838734319?pr=13800

[yeikel]

@markhallen Do you have any other feedback about this or any other command I should try?

[JamieMagee]

Do we need to add a require "excon" here?

[yeikel]

Why do you think that is? I may be missing something but that class takes Dependabot::Service as a constructor argument, and within service there is another injection, but I see no direct references to excon here. Is this class not tested in any other way?

[JamieMagee]

Thanks for doing this! Looks great.

We may want to do a follow-up to investigate using SharedHelpers.excon_defaults, but that shouldn't delay this.

[yeikel]

Thanks for doing this! Looks great.

We may want to do a follow-up to investigate using SharedHelpers.excon_defaults, but that shouldn't delay this.

Thanks for the feedback. I wasn’t aware of that helper.

If I’m understanding correctly, you’re referring to this change: 1dd17b7

The repo is currently rate-limited, but the tests are currently running on my fork: yeikel#235

Let me know your preference. We can include it here or I can revert it and handle it separately

[JamieMagee]

This looks fine to me. Thanks again.