Skip to content

Add CI job that runs KNOWNBUG tests #1222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
60 changes: 60 additions & 0 deletions .github/workflows/pull-request-checks.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -125,6 +125,12 @@ jobs:
name: ebmc-binary
retention-days: 5
path: src/ebmc/ebmc
- name: Upload the hw-cbmc binary
uses: actions/upload-artifact@v4
with:
name: hw-cbmc-binary
retention-days: 5
path: src/hw-cbmc/hw-cbmc
- name: Upload the vlindex binary
uses: actions/upload-artifact@v4
with:
Expand Down Expand Up @@ -457,3 +463,57 @@ jobs:
run: make CXX=clcache BUILD_ENV=MSVC -j4 -C unit
- name: Print ccache stats
run: clcache -s

# This job takes approximately 2 minutes
check-ubuntu-24_04-make-clang-KNOWNBUG:
runs-on: ubuntu-24.04
needs: check-ubuntu-24_04-make-clang
steps:
- uses: actions/checkout@v4
with:
submodules: recursive
- name: Fetch dependencies
env:
# This is needed in addition to -yq to prevent apt-get from asking for
# user input
DEBIAN_FRONTEND: noninteractive
run: |
sudo apt-get update
sudo apt-get install --no-install-recommends -yq z3
- name: Confirm z3 solver is available and log the version installed
run: z3 --version
- name: Get the ebmc binary
uses: actions/download-artifact@v4
with:
name: ebmc-binary
path: bin
- name: Get the hw-cbmc binary
uses: actions/download-artifact@v4
with:
name: hw-cbmc-binary
path: bin
- name: Get the vlindex binary
uses: actions/download-artifact@v4
with:
name: vlindex-binary
path: bin
- name: Try the binaries
run: |
chmod a+x ./bin/ebmc ; ./bin/ebmc --version
chmod a+x ./bin/hw-cbmc ; ./bin/hw-cbmc --version
chmod a+x ./bin/vlindex ; ./bin/vlindex --version
echo "PATH=$PATH:$PWD/bin" >> $GITHUB_ENV
- name: Run the ebmc tests with SAT
run: make -C regression/ebmc test TEST_PL="../../lib/cbmc/regression/test.pl -K"
- name: Run the ebmc tests with Z3
run: make -C regression/ebmc test-z3 TEST_PL="../../lib/cbmc/regression/test.pl -K"
- name: Run the verilog tests
run: make -C regression/verilog test TEST_PL="../../lib/cbmc/regression/test.pl -K"
- name: Run the verilog tests with Z3
run: make -C regression/verilog test-z3 TEST_PL="../../lib/cbmc/regression/test.pl -K"
- name: Run the smv tests
run: make -C regression/smv test TEST_PL="../../lib/cbmc/regression/test.pl -K"
- name: Run the smv tests with Z3
run: make -C regression/smv test-z3 TEST_PL="../../lib/cbmc/regression/test.pl -K"
- name: Run the vlindex tests
run: make -C regression/vlindex test TEST_PL="../../lib/cbmc/regression/test.pl -K"
163 changes: 0 additions & 163 deletions regression/ebmc/test.pl

This file was deleted.

6 changes: 4 additions & 2 deletions regression/hw-cbmc/Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
default: tests.log

TEST_PL = ../../lib/cbmc/regression/test.pl

test:
@../test.pl -e -p -c ../../../src/hw-cbmc/hw-cbmc
@$(TEST_PL) -e -p -c ../../../src/hw-cbmc/hw-cbmc

tests.log:
@../test.pl -e -p -c ../../../src/hw-cbmc/hw-cbmc
@$(TEST_PL) -e -p -c ../../../src/hw-cbmc/hw-cbmc

show:
@for dir in *; do \
Expand Down
3 changes: 1 addition & 2 deletions regression/verilog/enums/enum_in_assert.desc
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
KNOWNBUG
CORE
enum_in_assert.sv

^EXIT=0$
^SIGNAL=0$
--
--
This throws an exception.
2 changes: 1 addition & 1 deletion regression/verilog/enums/enum_name_collision.desc
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
KNOWNBUG
CORE
enum_name_collision.sv

^EXIT=2$
Expand Down
6 changes: 4 additions & 2 deletions regression/vhdl/Makefile
Original file line number Diff line number Diff line change
@@ -1,10 +1,12 @@
default: tests.log

TEST_PL = ../../lib/cbmc/regression/test.pl

test:
@../test.pl -e -p -c ../../../src/ebmc/ebmc
@$(TEST_PL) -e -p -c ../../../src/ebmc/ebmc

tests.log:
@../test.pl -e -p -c ../../../src/ebmc/ebmc
@$(TEST_PL) -e -p -c ../../../src/ebmc/ebmc

show:
@for dir in *; do \
Expand Down
Loading