Fix REF1 to behave analogous to the other REF macros #2191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
REF1 is currently only used once in entire DRuntime and Phobos, so maybe a special OBJECTREF macro would have been better? Anyhow, have a look at the only use of `REF1` to understand the motivation for this PR: https://dlang.org/phobos/std_file.html#.thisExePath Also there are three other PRs being blocked on this: - dlang/dmd#7342 - dlang/druntime#2082 - dlang/phobos#6140
Contributor
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
This was referenced Feb 8, 2018
JinShil
approved these changes
Feb 8, 2018
Contributor
Author
|
Ping @CyberShadow or others - as the Phobos PR has already been merged, this leaves the current preview https://dlang.org/phobos-prerelease/std_process.html#.ProcessPipes.stdin (or check the diff) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
REF1 is currently only used once in entire DRuntime and Phobos, so maybe
a special OBJECTREF macro would have been better?
Anyhow, have a look at the only use of
REF1to understand themotivation for this PR:
https://dlang.org/phobos/std_file.html#.thisExePath
Also there are three other PRs being blocked on this: