-
-
Notifications
You must be signed in to change notification settings - Fork 747
Use REF1 macro instead of OBJECTREF #6140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
REF1 is currently only used once in entire DRuntime and Phobos, so maybe a special OBJECTREF macro would have been better? Anyhow, have a look at the only use of `REF1` to understand the motivation for this PR: https://dlang.org/phobos/std_file.html#.thisExePath Also there are three other PRs being blocked on this: - dlang/dmd#7342 - dlang/druntime#2082 - dlang/phobos#6140
Not sure about this. There's 4 Some commentary on Wikipedia: |
😱 - maybe we need a typography styleguide too 😕 |
|
@wilzbach Don't be silly. Please add it back. Documentation should not without good reason use spellings that a majority of readers will perceive as an error. |
In my experience, anything that is potentially controversial in a PR can (or will) block it.
Sure. Let's have the discussion here: #6141 |
CyberShadow
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks like this fixes some broken HTML in DDox, though browsers treated it the same before and after.
The REF1 macro should have been used here instead.
See also: dlang/dlang.org#2191
edit: also fixed a few typos while I was at it.