Skip to content

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Feb 8, 2018

The REF1 macro should have been used here instead.

See also: dlang/dlang.org#2191

edit: also fixed a few typos while I was at it.

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach added a commit to wilzbach/dlang.org that referenced this pull request Feb 8, 2018
REF1 is currently only used once in entire DRuntime and Phobos, so maybe
a special OBJECTREF macro would have been better?
Anyhow, have a look at the only use of `REF1` to understand the
motivation for this PR:

https://dlang.org/phobos/std_file.html#.thisExePath

Also there are three other PRs being blocked on this:

- dlang/dmd#7342
- dlang/druntime#2082
- dlang/phobos#6140
@CyberShadow
Copy link
Member

child process's standard streams

Not sure about this. There's 4 s letters in a row here.

Some commentary on Wikipedia:
https://en.wikipedia.org/wiki/Apostrophe#Singular_nouns_ending_with_an_%22s%22_or_%22z%22_sound

@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 8, 2018

The Supreme Court of the United States is split on whether a possessive singular noun that ends with s should always have an additional s after the apostrophe, sometimes have an additional s after the apostrophe (for instance, based on whether the final sound of the original word is pronounced /s/ or /z/), or never have an additional s after the apostrophe. The informal majority view (5–4, based on past writings of the justices) has favoured the additional s, but a strong minority disagrees.

😱 - maybe we need a typography styleguide too 😕
Okay will drop the second commit for now.

@wilzbach wilzbach changed the title Add missing 's Use REF1 macro instead of OBJECTREF Feb 8, 2018
@wilzbach wilzbach added Severity:Documentation Review:Trivial typos, formatting, comments labels Feb 8, 2018
@n8sh
Copy link
Member

n8sh commented Feb 8, 2018

@wilzbach Don't be silly. Please add it back. Documentation should not without good reason use spellings that a majority of readers will perceive as an error.

@wilzbach wilzbach mentioned this pull request Feb 8, 2018
@wilzbach
Copy link
Contributor Author

wilzbach commented Feb 8, 2018

Don't be silly.

In my experience, anything that is potentially controversial in a PR can (or will) block it.
Hence, it's better to move such things into separate PRs, s.t. the main PR can be merged quickly.
I submitted this because of the REF1 macro (sorry for screwing up the initial title) - that is/was my main concern.

Please add it back.

Sure. Let's have the discussion here: #6141

Copy link
Member

@CyberShadow CyberShadow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Looks like this fixes some broken HTML in DDox, though browsers treated it the same before and after.

@dlang-bot dlang-bot merged commit 4933e91 into dlang:master Feb 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants