Deprecate class allocators and deallocators #8042

JinShil · 2018-03-16T13:10:31Z

delete was deprecated in 2.079. Before the delete keyword can be removed it will be necessary to also deprecate and remove class allocators and deallocators. They have been planned for deprecation for years; this PR finally puts the deprecation process in motion.

See https://dlang.org/deprecate.html#Class%20allocators%20and%20deallocators

dlang.org PR: dlang/dlang.org#2277

dlang-bot · 2018-03-16T13:10:32Z

Thanks for your pull request, @JinShil!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

wilzbach · 2018-03-16T16:54:27Z

changelog/deprecate_class_allocators.dd

+}
+---
+
+For more information see https://dlang.org/deprecate.html#Class%20allocators%20and%20deallocators


Probably a good idea to point users to alternatives like std.experimental.allocator and other RAII articles.
See also: https://issues.dlang.org/show_bug.cgi?id=18613

Please enumerate specifically which articles I should include and I'll add them.

Probably this page is the best we have at the moment - https://dlang.org/blog/the-gc-series

It doesn't really mention stdx.allocator, so I would probably mentioned that separately.

How about:

Many alternatives for class allocators/deallcators exist, among many is the generic $(REF make, std,experimental,allocator) and $(REF dispose, std,experimental,allocator) from the allocator package. For other alternatives, see $(LINK2 https://dlang.org/blog/the-gc-series, the recent article about memory allocation on the DBlog)

(just an idea)

Done. Thanks!

wilzbach · 2018-03-16T16:55:29Z

src/dmd/dsymbolsem.d

    {
        //printf("NewDeclaration::semantic()\n");
+
+        // @@@DEPRECATED_2019-05@@@


We recently switched to using an explicit version, see also dlang/DIPs#108 or dlang/phobos#6286 for an example

ghost

Please don't do this for class allocators. We have recently discovered that they can be used to prevent the usage of new (when marked @disable hence forcing people to use custom phobos-style allocators.

I planned to add this to my user library but forgot to. This user library is now in the project tester so this change would really be embarassing.

For deallocators ok since delete is deprecated.

JinShil · 2018-03-16T20:24:40Z

I've added support for the syntax @disable new();. You won't even need to add the useless size_t argument. That should prevent any breaking changes.

ghost

This new version allows the @disable trick so it's good.

wilzbach · 2018-03-18T11:00:40Z

changelog/deprecate_class_allocators.dd

+    }
+}
+---
+


The new @disable new(); syntax should be mentioned here.

wilzbach

Nice!

JinShil · 2018-03-23T01:35:37Z

I'm labeling this as "Vision", as I think it corresponds to item 1 in the stated vision.

Lock down the language definition: D is a powerful language but its definition is not precise enough. A number of subtleties can only be assessed only by running the compiler, not by perusing the specification. This semester we are pushing for a better, more precise, and more complete specification of the D language.

While that statement was probably intended largely for documentation, there are two sides to that coin: 1. ensuring the specification documents the implementation, 2. ensuring the code implements the documentation; they are one and the same.

Deprecations are updates to the specification. Documenting that something is deprecated without actually implementing said deprecation is to disregard the specification.

Moving these deprecations forward is locking down the language, and doing it sooner rather than later avoids problems that crop up when users choose to leverage a deprecated feature in some unexpected way, forcing us to make accomodations later.

wilzbach · 2018-03-26T02:05:04Z

@WalterBright @andralex I think your approval for this deprecation is required?
(it's more a formal thing because it has been on the list of to be deprecated for a long time)

andralex · 2018-03-30T11:14:14Z

Affirmative. Let's move with deprecation. Thanks.

wilzbach · 2018-03-30T18:22:02Z

Windows failure is unrelated -> braddr/d-tester#71

There was one spurious failure on OSX in druntime

https://auto-tester.puremagic.com/show-run.ghtml?projectid=1&runid=3098596&isPull=true

Testing invalid_memory_operation
timelimit -t 10 ./generated/osx/debug/32/invalid_memory_operation  2>&1 1>/dev/null | grep -qF "InvalidMemoryOperationError"
timelimit -t 10 generated/osx/release/32/unittest/test_runner core.sys.dragonflybsd.netinet.in_
make[2]: *** [generated/osx/debug/32/invalid_memory_operation.done] Error 1
rm generated/osx/debug/32/unknown_gc generated/osx/debug/32/stderr_msg generated/osx/debug/32/static_dtor generated/osx/debug/32/future_message generated/osx/debug/32/invalid_memory_operation
make[1]: *** [test/exceptions/.run] Error 2
make: *** [unittest-debug] Error 2
make: *** Waiting for unfinished jobs....
```

Let's see whether this is repeats itself - otherwise "merge ahoy!"

JinShil mentioned this pull request Mar 16, 2018

Deprecate class allocators and deallocators dlang/dlang.org#2277

Merged

wilzbach reviewed Mar 16, 2018

View reviewed changes

ghost suggested changes Mar 16, 2018

View reviewed changes

ghost approved these changes Mar 16, 2018

View reviewed changes

wilzbach reviewed Mar 18, 2018

View reviewed changes

Deprecate class allocators and deallocators

774c395

wilzbach approved these changes Mar 22, 2018

View reviewed changes

wilzbach added this to the 2.080.0 milestone Mar 22, 2018

Fix link to deprecated features in changelog

2ccb66b

JinShil added the Review:Vision Vision Plan https://wiki.dlang.org/Vision/2018H1 label Mar 23, 2018

wilzbach assigned andralex and WalterBright Mar 26, 2018

RazvanN7 approved these changes Mar 30, 2018

View reviewed changes

wilzbach added the Merge:72h no objection -> merge The PR will be merged if there are no objections raised. label Mar 30, 2018

andralex approved these changes Mar 30, 2018

View reviewed changes

wilzbach added Merge:auto-merge and removed Merge:72h no objection -> merge The PR will be merged if there are no objections raised. labels Mar 30, 2018

dlang-bot merged commit c83e4b5 into dlang:master Mar 30, 2018

JinShil deleted the deprecate_class_allocators branch April 24, 2018 10:17

RazvanN7 mentioned this pull request Nov 22, 2018

Fix Issue 19419 - [REG2.080.1] @disabled this() will print wrong error if calling non-default constructor with wrong parameters #8994

Merged

JinShil mentioned this pull request May 15, 2019

Advance deprecation of class allocators and deallocators: Removal #9786

Merged

JinShil mentioned this pull request Jan 16, 2020

Remove class deallocator following deprecation #10727

Merged

Uh oh!

Deprecate class allocators and deallocators #8042

Deprecate class allocators and deallocators #8042

Uh oh!

Conversation

JinShil commented Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dlang-bot commented Mar 16, 2018

Bugzilla references

Uh oh!

wilzbach Mar 16, 2018

Choose a reason for hiding this comment

Uh oh!

JinShil Mar 16, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

wilzbach Mar 18, 2018

Choose a reason for hiding this comment

Uh oh!

JinShil Mar 18, 2018

Choose a reason for hiding this comment

Uh oh!

wilzbach Mar 16, 2018

Choose a reason for hiding this comment

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

JinShil commented Mar 16, 2018

Uh oh!

ghost left a comment

Choose a reason for hiding this comment

Uh oh!

wilzbach Mar 18, 2018

Choose a reason for hiding this comment

Uh oh!

JinShil Mar 18, 2018

Choose a reason for hiding this comment

Uh oh!

wilzbach left a comment

Choose a reason for hiding this comment

Uh oh!

JinShil commented Mar 23, 2018

Uh oh!

wilzbach commented Mar 26, 2018

Uh oh!

andralex commented Mar 30, 2018

Uh oh!

wilzbach commented Mar 30, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

JinShil commented Mar 16, 2018 •

edited

Loading

JinShil Mar 16, 2018 •

edited

Loading