Skip to content
This repository was archived by the owner on Oct 12, 2022. It is now read-only.
/ druntime Public archive

Conversation

@wilzbach
Copy link
Contributor

Required for dlang/dmd#7440

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach added the Trivial typos, formatting, comments label Dec 15, 2017
posix.mak Outdated

$(DOCDIR)/object.html : src/object.d
$(DMD) $(DDOCFLAGS) -Df$@ project.ddoc $(DOCFMT) $<
$(DMD) $(DDOCFLAGS) -Df$@ project.ddoc $(DOCFMT) $< 2>&1 | grep "Warning:"; test $$? -eq 1
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think all you need to set the error level is grep -v "Warning:".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also a problem with this pattern is that if dmd fails with no warning the command will succeed.

@wilzbach
Copy link
Contributor Author

Okay I removed the explicit grepping for error messages and rebased the PR to just contain the Ddoc fix so that it's absolutely non-controversial and we can move on with this, because once this is merged we can merge the dlang/dmd#7440 at DMD and then -w will work as expected with a proper exit code and no grepping is required.

@dlang-bot dlang-bot merged commit cd79cf6 into dlang:master Dec 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

Blocking Other Work Trivial typos, formatting, comments

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants