Skip to content

Fix Issue 18083 - -w doesn't work for the ddoc build #7440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
wilzbach merged 2 commits into from
Dec 21, 2017
Merged

Fix Issue 18083 - -w doesn't work for the ddoc build #7440

wilzbach merged 2 commits into from
Dec 21, 2017

Conversation

@wilzbach
Copy link
Contributor

@wilzbach wilzbach commented Dec 15, 2017 •
edited
Loading

@wilzbach wilzbach added the Review:Trivial typos, formatting, comments label Dec 15, 2017
@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 15, 2017 •
edited
Loading

Thanks for your pull request, @wilzbach!

Bugzilla references

Auto-close Bugzilla Description
✓ 18083 -w doesn't work for the ddoc build

@wilzbach wilzbach mentioned this pull request Dec 15, 2017
Merged
@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 15, 2017

Great, before we fix this druntime needs to fixed too as druntime uses -w for the documentation build, e.g.

src/core/bitop.d(387): Warning: Ddoc: parameter count mismatch

@wilzbach wilzbach mentioned this pull request Dec 15, 2017
Merged
jacob-carlborg
jacob-carlborg reviewed Dec 15, 2017
View reviewed changes
test/fail_compilation/ddoc_18083.d Outdated
Params:
this = non-existent parameter
*/
int foo() {
Copy link
Contributor

@jacob-carlborg jacob-carlborg Dec 15, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nitpick: curly braces on their own lines.

@wilzbach wilzbach force-pushed the fix-18083 branch 3 times, most recently from ef288e5 to ef878ba Compare December 18, 2017 05:42
@wilzbach
Copy link
Contributor Author

wilzbach commented Dec 19, 2017 •
edited
Loading

auto-tester is finally happy with this 👻
The Jenkins failure looks unrelated (restarted).

@wilzbach wilzbach merged commit b70e411 into dlang:master Dec 21, 2017
@wilzbach wilzbach deleted the fix-18083 branch December 21, 2017 09:12
@wilzbach wilzbach mentioned this pull request Feb 5, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PetarKirov PetarKirov PetarKirov approved these changes

@WalterBright WalterBright Awaiting requested review from WalterBright WalterBright is a code owner

+1 more reviewer

@jacob-carlborg jacob-carlborg jacob-carlborg left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Review:Trivial typos, formatting, comments Severity:Bug Fix

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wilzbach @dlang-bot @jacob-carlborg @PetarKirov