-
-
Notifications
You must be signed in to change notification settings - Fork 747
Add missing 's #6141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing 's #6141
Conversation
|
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
I think this pull request should go ahead. Technical documentation should not without good reason use spellings that a majority of readers will perceive as errors. Perceived spelling mistakes are distracting and give a document a slipshod appearance regardless of whether they are truly mistakes or are accepted alternative spellings. |
Is the current year after 1810? |
|
Found this: http://www.thepunctuationguide.com/apostrophe.html
|
|
Technically, words that end with s take only an apostrophe without another s. But seriously, this is a ridiculous amount of spat over a minor grammar nitpick. I say we should just reword the entire lousy sentence to read something like "X of Y" instead of "Y's X". E.g., "the environment of the child process" instead of "the child process('s|'|s|whatever) environment". The former is much clearer to read anyway, and sidesteps this entire lousy argument. |
|
Let's not start grammar fights and introduce useless churn into Phobos. I'm not even supportive of changing everything to one consistent style; just leave it as it is. |
|
From the resource @schveiguy posted:
Maybe we should add this excellent Punctuation Guide to the Phobos part of the DStyle? It would help to avoid such discussions in the future as there is a goto resource we can link to.
Fair enough.
I disagree - a consistent style is important. It leaves an unprofessional touch. |
(This seems to be a controversial topic)
#6140 (comment)