Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 6 additions & 9 deletions .github/dependency-review-config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,21 +32,18 @@ deny-licenses:
# Allow specific packages even if they fail other checks
allow-dependencies-licenses:
# Core Rust ecosystem crates that are essential
- package-name: "serde"
- package-name: "serde_json"
- package-name: "tokio"
- package-name: "clap"
- serde
- serde_json
- tokio
- clap

# Deny specific packages
deny-packages:
# Example of denying packages with known issues
- package-name: "openssl-sys"
reason: "Prefer rustls for pure Rust TLS implementation"
- openssl-sys

# Allow vulnerabilities for specific advisories (temporary exceptions)
allow-ghsas:
# Example: Allow specific GitHub Security Advisories temporarily
# - "GHSA-xxxx-xxxx-xxxx"
allow-ghsas: []

# Configuration for comment behavior
comment-summary-in-pr: auto
Expand Down
10 changes: 5 additions & 5 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ jobs:
if: ${{ !inputs.cache_key }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@stable
with:
components: rustfmt
Expand All @@ -76,7 +76,7 @@ jobs:
if: ${{ !inputs.cache_key }}
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
- uses: dtolnay/rust-toolchain@stable
with:
components: clippy
Expand All @@ -103,7 +103,7 @@ jobs:
rust: beta
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6

# Setup cross-platform helper functions
- name: Load helper functions
Expand Down Expand Up @@ -268,7 +268,7 @@ jobs:

- name: Download build artifacts (if available)
if: inputs.cache_key != ''
uses: actions/download-artifact@v5
uses: actions/download-artifact@v6
with:
name: build-artifacts-${{ matrix.os }}
path: target/
Expand Down Expand Up @@ -526,7 +526,7 @@ jobs:
name: Minimum Supported Rust Version
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6

# Setup cross-platform helper functions
- name: Load helper functions
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/master-pipeline.yml
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ jobs:
should_run_release: ${{ steps.config.outputs.should_run_release }}
release_tag: ${{ steps.config.outputs.release_tag }}
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6

# Setup cross-platform helper functions
- name: Load helper functions
Expand Down Expand Up @@ -217,7 +217,7 @@ jobs:

# Upload build artifacts for other jobs to use
- name: Upload build artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: build-artifacts-${{ runner.os }}
Comment on lines 218 to 222
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Use published upload-artifact action version

The master pipeline now references actions/upload-artifact@v5, but the upstream action is only published up to v4; GitHub fails the step with “Unable to resolve action actions/upload-artifact@v5” before any artifacts are uploaded, which blocks downstream jobs that expect those build artifacts. The previous config used v4 (valid), so this change introduces a CI break across builds triggered by this workflow (and similarly updated workflows).

Useful? React with 👍 / 👎.

path: |
Expand Down Expand Up @@ -317,7 +317,7 @@ jobs:
permissions:
contents: read
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6

- uses: dtolnay/rust-toolchain@stable
with:
Expand Down Expand Up @@ -393,7 +393,7 @@ jobs:
EOF

- name: Upload documentation artifacts
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: documentation
path: target/doc/
Expand Down Expand Up @@ -428,7 +428,7 @@ jobs:
contents: read
id-token: write
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6

- uses: dtolnay/rust-toolchain@stable

Expand Down Expand Up @@ -500,7 +500,7 @@ jobs:
artifact_name: rustirc-macos-arm64.tar.gz
runs-on: ${{ matrix.os }}
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down Expand Up @@ -549,7 +549,7 @@ jobs:
7z a ../../../${{ matrix.artifact_name }} rustirc.exe
shell: pwsh
- name: Upload build artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: ${{ matrix.artifact_name }}
path: ${{ matrix.artifact_name }}
Expand All @@ -571,12 +571,12 @@ jobs:
contents: write
discussions: write
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Download artifacts
uses: actions/download-artifact@v5
uses: actions/download-artifact@v6
with:
path: artifacts

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ jobs:
permissions:
contents: read
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down Expand Up @@ -120,7 +120,7 @@ jobs:
shell: bash

- name: Upload artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
with:
name: ${{ matrix.asset_name }}
path: |
Expand All @@ -138,12 +138,12 @@ jobs:
contents: write
discussions: write
steps:
- uses: actions/checkout@v5
- uses: actions/checkout@v6
with:
fetch-depth: 0

- name: Download all artifacts
uses: actions/download-artifact@v5
uses: actions/download-artifact@v6
with:
path: artifacts

Expand Down
25 changes: 15 additions & 10 deletions .github/workflows/security-audit.yml
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ jobs:
actions: read
steps:
- name: Checkout code
uses: actions/checkout@v5
uses: actions/checkout@v6
with:
fetch-depth: 0

Expand Down Expand Up @@ -211,7 +211,7 @@ jobs:
echo "count=$total" >> $GITHUB_OUTPUT

- name: Upload audit results as artifact
uses: actions/upload-artifact@v4
uses: actions/upload-artifact@v5
if: always()
with:
name: security-audit-results
Expand All @@ -221,19 +221,24 @@ jobs:
retention-days: 30

- name: Comment audit summary on PR
if: github.event_name == 'pull_request'
if: github.event_name == 'pull_request' && github.event.pull_request
continue-on-error: true
uses: actions/github-script@v8
with:
script: |
const fs = require('fs');
if (fs.existsSync('audit_summary.md')) {
const summary = fs.readFileSync('audit_summary.md', 'utf8');
github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: `## 🛡️ Security Audit Results\n\n${summary}`
});
try {
await github.rest.issues.createComment({
issue_number: context.issue.number,
owner: context.repo.owner,
repo: context.repo.repo,
body: `## 🛡️ Security Audit Results\n\n${summary}`
});
} catch (error) {
console.log('Unable to post comment (may be called from workflow_call):', error.message);
}
}

dependency-review:
Expand All @@ -245,7 +250,7 @@ jobs:
pull-requests: write
steps:
- name: Checkout code
uses: actions/checkout@v5
uses: actions/checkout@v6

- name: Dependency Review
uses: actions/dependency-review-action@v4
Expand Down
Loading
Loading