Add doveadm_http_request_finished event #1373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
sirainen
reviewed
Dec 11, 2025
|
|
||
| doveadm_http_request_finished: { | ||
| inherit: 'connection_client_finished', | ||
| fields: { |
Contributor
There was a problem hiding this comment.
Shouldn't we rather reuse http_server_request_finished event?...
Contributor
Author
There was a problem hiding this comment.
well, maybe, but i haven't yet tried to use that. also this is bit of a silly thing because there might be multiple commands in single request
Contributor
There was a problem hiding this comment.
and/or do we want this to be HTTP specific rather than doveadm command specific, which would work also for TCP commands? doveadm_command_finished?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
JIRA: DOV-7841