Skip to content

Add doveadm_http_request_finished event #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cmouse wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add doveadm_http_request_finished event #1373

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fb300dc
Add doveadm_http_request_finished event
cmouse Dec 11, 2025
789dbbd
upgrade: Add upgrade note about logging
cmouse Dec 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions data/events.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1896,4 +1896,22 @@ characters and no control characters.
sql_driver: `Name of the sql driver, e.g. \`mysql\` or \`cassandra\`.`,
},
},

doveadm_http_request_finished: {
inherit: 'connection_client_finished',
fields: {
Copy link
Contributor

@sirainen sirainen Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we rather reuse http_server_request_finished event?...

Copy link
Contributor Author

@cmouse cmouse Dec 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well, maybe, but i haven't yet tried to use that. also this is bit of a silly thing because there might be multiple commands in single request

Copy link
Contributor

@sirainen sirainen Dec 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and/or do we want this to be HTTP specific rather than doveadm command specific, which would work also for TCP commands? doveadm_command_finished?

local_port: `Local port.`,
remote_ip: `Remote IP address.`,
remote_port: `Remote port.`,
user: `Full username.`,
command: `Doveadm command used`,
exit_code: `Exit code of the command`,
method: `HTTP method used`,
url: `HTTP URL used`,
agent: `Value of User-Agent header`,
http_status: `HTTP response status code`,
http_reason: `Reason for status code`,
},
},

}
6 changes: 6 additions & 0 deletions docs/installation/upgrade/2.4-to-2.4.x.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,12 @@ changed to `2.4.2`.

### v2.4.2 to v2.4.3

#### Logging change

Doveadm HTTP client logging is changed to event based, so the Apache-style status line is no longer logged,
you can still log using [[event,doveadm_http_request_finished]] with [[link,event_exporter]], but the format
will be different.

#### Changed Setting Defaults

These changes don't take effect until [[setting,dovecot_config_version]] is
Expand Down
Loading