-
Notifications
You must be signed in to change notification settings - Fork 3
[PR] Adding DQ_CoppeliaSimInterfaceZMQ and DQ_CoppeliaSimInterfaceZMQ Extended #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
bvadorno
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @juanjqo,
Please use more descriptive messages in your commits. "Made some modifications. But it is not working yet" is cryptic and unhelpful (what modifications?).
Thanks,
Bruno
…ppeliaSimInterfaceZMQ class. This strategy however, it is not suitable to allow low-level access from the experimental class. I removed temporarily from the CMake project the classes that require the DQ_CoppeliaSimInterfaceZMQ.
…d between the ZMQInterfaces.
…between the two classes. Cleaning up repeated methods in the Experimental class.
…mbols in both classes by adding the implementation on the cpp and moving the template out to the header..
…were already defined in the parent class.
…methods add_primitive and object_exist_on_scene. However, there are more duplications to remove.
…xperimental class except the ones that perform intermediary steps in some plot methods. Fixed bug related to unit quaternion norm when the Newton engine is used.
…ch I used to perform internal tests.
…are not used anymore.
|
Hi @bvadorno and @mmmarinho I had a hard time implementing the @bvadorno's suggestion. But I think is ready. Thanks, @mmmarinho, for the clarification of some C++ concepts and for the implementation of the internal wrapper. The other classes, as Kind regards, Juancho |
|
Thanks @juanjqo. I need to merge this pull request as a matter of urgency so that I can prepare my materials for next week's workshop. I'll add some other instructions to issue #1. These will include what @juanjqo mentioned about some remaining tasks to make this interface fully compatible. It is better that we split this task into multiple pull requests otherwise we will have a difficult monster to handle. In addition, I'll have more experience with this interface to propose improvements. Before I forget, @juanjqo, when you have the time, please adjust the UML to reflect what was done in this pull request. Lastly, just FYI, to help disambiguate, I've added the string "[Murilo]" to the commits I made using the shared PC with Juan. |
@dqrobotics/developers
This PR adds the first official version of the new DQ Robotics interface to connect with CoppeliaSim based on ZeroMQ remote API. This PR the abstract class
DQ_CoppeliaSimInterface(), which I proposed here.The new class
DQ_CoppeliaSimZmqInterface()implements all methods of the superclassDQ_CoppeliaSimInterface().Furthermore, the exclusive methods that are enabled by the ZeroMQ remote API are implemented in a different namespace called experimental. I added two examples in my own public repository https://github.com/juanjqo/dqrobotics-interface-coppeliasim-examples/tree/dqrobotics.
Furthermore, this PR proposes the following classes
DQ_SerialCoppeliaSimRobot,DQ_SerialCoppeliaSimZmqRobotand, two robot classesURXCoppeliaSimZmqRobotandFrankaEmikaPandaCoppeliaSimZmqRobot.Initial propose
Final version
Best regards,
Juancho