Open
Conversation
Owner
|
It would be good to showcase/mention here shortly how you came to the conclusion that it was semi-successful. iirc, this interpretation was based on this finding below, showing basically equal performance of early vs. strategy of "waiting 60% of trial only under highest reward and steepest slope", under a 30% starting point setting.
However, the same pattern was shown with a 50% starting point. - Making me think that it is rather about the strategy here, which was kept equal. If the parameters you changed were shown to be effective, it would be good to parametrize rather than hardcode it, for the PR to be accepted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
semi-successfull so far