Fix live show "Go to Page" navigation for pages 100+#876
Merged
Conversation
Parse page numbers as integers in loadCompiledScript() to fix string comparison bug. Object.entries() returns keys as strings, causing "100" > "99" to evaluate false (lexicographic comparison). Also add Number() defense-in-depth in navigateTo() check. Fixes #875 Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
github-actions
bot
added
client
Client Test Results83 tests 83 ✅ 0s ⏱️ Results for commit 7ce75cc. |
Python Test Results 1 files 1 suites 38s ⏱️ Results for commit 7ce75cc. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
loadCompiledScript()that prevented "Go to Page" from working for pages 100+Object.entries()returns page numbers as strings, causing"100" > "99"to evaluatefalse(lexicographic comparison)parseInt()to convert page keys to integers before comparisonNumber()defense-in-depth innavigateTo()checkRoot Cause
When comparing page numbers to find
maxLoadedPage, string comparison was used:"100" > "99"compares"1"vs"9"→falsemaxLoadedPageto incorrectly cap at"99"Test plan
Fixes #875
🤖 Generated with Claude Code