Skip to content

Fix live show "Go to Page" navigation for pages 100+ #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Tim020 merged 1 commit into from
Jan 26, 2026
Merged

Fix live show "Go to Page" navigation for pages 100+ #876

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions client/src/views/show/ShowLiveView.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -558,7 +558,8 @@ export default {
},
navigateTo(targetPage, targetLineOnPage, preventScroll = false) {
// Check if the page is loaded
if (targetPage > this.currentLoadedPage) {
// Use Number() for defense-in-depth in case currentLoadedPage is ever a string
if (targetPage > Number(this.currentLoadedPage)) {
return false;
}

Expand Down Expand Up @@ -975,7 +976,7 @@ export default {
let minLoadedPage = Number.POSITIVE_INFINITY;
const respJson = await response.json();
Object.entries(respJson).forEach((value) => {
const pageNumber = value[0];
const pageNumber = parseInt(value[0], 10);
const pageContents = value[1];

if (pageNumber > maxLoadedPage) {
Expand Down
Loading