Fix InsertRelation on attached database #155
Merged
+6
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tishj
reviewed
Nov 5, 2025
Tishj
reviewed
Nov 5, 2025
Tishj
requested changes
Nov 5, 2025
Collaborator
Tishj
left a comment
Tishj
left a comment
There was a problem hiding this comment.
I have some questions, but I'm also missing a test
evertlammerts
force-pushed
the
insert_rel_fix
branch
from
57d7a05 to
c26e02d
Compare
lnkuiper
added a commit
to duckdb/duckdb
that referenced
this pull request
Nov 7, 2025
Fixes #18396 Related PR in duckdb-python: duckdb/duckdb-python#155
evertlammerts
force-pushed
the
insert_rel_fix
branch
from
c26e02d to
97fd6c6
Compare
evertlammerts
force-pushed
the
insert_rel_fix
branch
from
97fd6c6 to
20bfd52
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes duckdb/duckdb#18396
related pr in core: duckdb/duckdb#19583
The checks of this PR can only run after duckdb/duckdb#19583 lands