Skip to content

Fix InsertRelation on attached database #155

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 10, 2025
+6 −12
Merged

Fix InsertRelation on attached database #155

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95a9968
Fix InsertRelation on attached database
evertlammerts Nov 1, 2025
20bfd52
review feedback
evertlammerts Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion external/duckdb
Open in desktop
Submodule duckdb updated 11 files
+1 −1 .github/config/extensions/aws.cmake
+1 −1 .github/config/extensions/ducklake.cmake
+1 −1 .github/config/extensions/httpfs.cmake
+1 −1 .github/config/extensions/iceberg.cmake
+6 −0 src/include/duckdb/common/http_util.hpp
+3 −0 src/include/duckdb/main/extension_entries.hpp
+6 −1 src/logging/log_types.cpp
+15 −0 src/main/http/http_util.cpp
+3 −1 src/parser/transform/expression/transform_cast.cpp
+6 −0 test/sql/json/test_json_serialize_sql.test
+26 −0 test/sql/logging/http_log_timing.test
2 changes: 1 addition & 1 deletion src/duckdb_py/include/duckdb_python/pyrelation.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -235,7 +235,7 @@ struct DuckDBPyRelation {

void InsertInto(const string &table);

void Insert(const py::object &params = py::list());
void Insert(const py::object &params = py::list()) const;
void Update(const py::object &set, const py::object &where = py::none());

void Create(const string &table);
Expand Down
10 changes: 3 additions & 7 deletions src/duckdb_py/pyrelation.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,14 +1511,10 @@ DuckDBPyRelation &DuckDBPyRelation::Execute() {
void DuckDBPyRelation::InsertInto(const string &table) {
AssertRelation();
auto parsed_info = QualifiedName::Parse(table);
auto insert = rel->InsertRel(parsed_info.schema, parsed_info.name);
auto insert = rel->InsertRel(parsed_info.catalog, parsed_info.schema, parsed_info.name);
PyExecuteRelation(insert);
}

static bool IsAcceptedInsertRelationType(const Relation &relation) {
return relation.type == RelationType::TABLE_RELATION;
}

void DuckDBPyRelation::Update(const py::object &set_p, const py::object &where) {
AssertRelation();
unique_ptr<ParsedExpression> condition;
Expand Down Expand Up @@ -1563,9 +1559,9 @@ void DuckDBPyRelation::Update(const py::object &set_p, const py::object &where)
return rel->Update(std::move(names), std::move(expressions), std::move(condition));
}

void DuckDBPyRelation::Insert(const py::object &params) {
void DuckDBPyRelation::Insert(const py::object &params) const {
AssertRelation();
if (!IsAcceptedInsertRelationType(*this->rel)) {
if (this->rel->type != RelationType::TABLE_RELATION) {
throw InvalidInputException("'DuckDBPyRelation.insert' can only be used on a table relation");
}
vector<vector<Value>> values {DuckDBPyConnection::TransformPythonParamList(params)};
Expand Down
4 changes: 1 addition & 3 deletions tests/fast/test_insert.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,4 @@ def test_insert_with_schema(self, duckdb_cursor):
res = duckdb_cursor.table("not_main.tbl").fetchall()
assert len(res) == 10

# TODO: This is not currently supported # noqa: TD002, TD003
with pytest.raises(duckdb.CatalogException, match="Table with name tbl does not exist"):
duckdb_cursor.table("not_main.tbl").insert([42, 21, 1337])
duckdb_cursor.table("not_main.tbl").insert((42,))
Loading