Skip to content

validate URL scheme before opening in url_opener (#21) #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dvoraj75 wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

validate URL scheme before opening in url_opener (#21) #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions forgewatch/url_opener.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,8 @@

logger = logging.getLogger(__name__)

_ALLOWED_SCHEMES = frozenset(("http", "https"))


# XDG Desktop Portal D-Bus coordinates. The portal allows sandboxed
# processes (systemd services, Flatpak, Snap) to open URLs in the
Expand All @@ -22,10 +24,20 @@
async def open_url(url: str) -> None:
"""Open *url* in the default browser.

Only ``http`` and ``https`` URLs are accepted. Any other scheme is
rejected with a warning to prevent opening arbitrary protocols via
``xdg-open`` or the XDG Desktop Portal.

Tries the XDG Desktop Portal first (works from sandboxed systemd
services), then falls back to ``xdg-open`` for environments where
the portal is unavailable (e.g. minimal window managers).
"""
from urllib.parse import urlparse

parsed = urlparse(url)
if parsed.scheme not in _ALLOWED_SCHEMES:
logger.warning("Rejected URL with disallowed scheme %r: %s", parsed.scheme, url)
return
if await _open_url_portal(url):
return
await _open_url_xdg(url)
Expand Down
Loading