validate URL scheme before opening in url_opener (#21)#61
Open
validate URL scheme before opening in url_opener (#21)#61
Conversation
dvoraj75
added
enhancement
Restrict open_url() to http:// and https:// schemes only. Malformed or unexpected URLs from the API (e.g. file://, javascript:, custom schemes) are now rejected with a warning log instead of being passed through to xdg-open or the XDG Desktop Portal. Closes #21
dvoraj75
force-pushed
the
feat/issue-21-validate-urls
branch
from
c7ec22a to
27df680
Compare
☂️ Python Coverage
Overall Coverage
New FilesNo new covered files... Modified Files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request introduces a security improvement to the
open_urlfunction inforgewatch/url_opener.pyby restricting which URL schemes can be opened. OnlyhttpandhttpsURLs are now permitted, preventing the opening of potentially unsafe or arbitrary protocols.Security enhancements:
open_urlfunction to only allow URLs withhttpandhttpsschemes, rejecting others with a warning to prevent misuse viaxdg-openor the XDG Desktop Portal. [1] [2]