[21114] Check suprocess return codes on RDT generation #795
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: eduponz <eduardoponz@eprosima.com>
7 tasks
Mario-DL
approved these changes
Jun 5, 2024
Author
|
@richiprosima please test_3 docs |
Author
|
@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x |
✅ Backports have been created
|
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
mergify bot
pushed a commit
that referenced
this pull request
Jun 5, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
7 tasks
Mario-DL
pushed a commit
that referenced
this pull request
Jun 27, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
EduPonz
added a commit
that referenced
this pull request
Jul 2, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
EduPonz
added a commit
that referenced
this pull request
Jul 3, 2024
* Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
JesusPoderoso
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
JesusPoderoso
pushed a commit
that referenced
this pull request
Jul 3, 2024
* Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Jul 3, 2024
* Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Check suprocess return codes on RDT generation (#795) (#796) * Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Refs #21114: TODO DROP - Check against Fast DDS branch Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> * Revert "Refs #21114: TODO DROP - Check against Fast DDS branch" This reverts commit fd27b9f. Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Signed-off-by: JesusPoderoso <jesuspoderoso@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com> Co-authored-by: JesusPoderoso <jesuspoderoso@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Jul 3, 2024
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) Check suprocess return codes on RDT generation (#795) (#796) * Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
EduPonz
added a commit
that referenced
this pull request
Jul 3, 2024
* Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) Check suprocess return codes on RDT generation (#795) (#796) * Check subprocess return codes on RDT generation (#795) Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196) * Refs #21114: Remove unsued Doxyfile EXAMPLE_PATH Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fix Fast DDS Python API reference warnings regarding Qos aliases Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Fail generation when docutils errors Signed-off-by: eduponz <eduardoponz@eprosima.com> * Refs #21114: Use correct branches of Fast DDS and Fast DDS Python in RTD Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com> * Set English as doc language Signed-off-by: eduponz <eduardoponz@eprosima.com> --------- Signed-off-by: eduponz <eduardoponz@eprosima.com> Co-authored-by: Eduardo Ponz Segrelles <eduardoponz@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the RDT generation to fail if either of the
doxygenorswigcommands fails. Not checking them was causing the documentation to build with API reference errors.@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Related implementation PR:
NOTE: As RTD build is not ready to take the appropriate Fast DDS branch and will choose
master, the build will failed until eProsima/Fast-DDS#4896 is merged. I've verified on a Ubuntu 20.04 docker that the doxygen is generated without errors with that Fast DDS PR.Contributor Checklist
Reviewer Checklist