[21114] Check suprocess return codes on RDT generation (backport #795) #799
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Signed-off-by: eduponz <eduardoponz@eprosima.com> (cherry picked from commit 0974196)
Mario-DL
force-pushed
the
mergify/bp/2.6.x/pr-795
branch
from
fa81240 to
0201c37
Compare
Contributor
|
@richiprosima please test docs |
|
This shall include changes similar to those introduced in: |
juanjo4936
pushed a commit
that referenced
this pull request
Jan 7, 2025
Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Contributor
|
Closing because the changes mentioned here have been included in PR #1010 |
rsanchez15
pushed a commit
that referenced
this pull request
Jan 16, 2025
* Refs #21777: Change the default branch if not set for python Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #21777: Change the default branch for FastDDs, and mimic 2.10.x format Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #21777: Default Pyhton branch set to 1.1.x Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #21777: Corrected typo Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> * Refs #21777: include checks like in 2.10.x, as described in PR #799 Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com> --------- Signed-off-by: Juanjo Garcia <juanjosegarcia@eprosima.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR makes the RDT generation to fail if either of the
doxygenorswigcommands fails. Not checking them was causing the documentation to build with API reference errors.@Mergifyio backport 2.14.x 2.13.x 2.10.x 2.6.x
Related implementation PR:
NOTE: As RTD build is not ready to take the appropriate Fast DDS branch and will choose
master, the build will failed until eProsima/Fast-DDS#4896 is merged. I've verified on a Ubuntu 20.04 docker that the doxygen is generated without errors with that Fast DDS PR.Contributor Checklist
Reviewer Checklist
This is an automatic backport of pull request #795 done by [Mergify](https://mergify.com).