This repository was archived by the owner on Oct 12, 2021. It is now read-only.
Remove any logic from isWriteable #22
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closes #21 Change-Id: I307ec568dd575bd87b8903770d4acf3166d22522 Signed-off-by: Andrew Berezovskyi <andriib@kth.se>
Contributor
Author
|
@jadelkhoury @jamsden please review |
Contributor
Author
|
Alternatively, we can switch to a new provider as shown in #76 and leave this without changes but I can't imagine how this change would cause any backwards compatibility problems. |
|
I am unable to review, clicking Add you review never completes. |
Contributor
Author
|
You can post it here if you wish. |
jadelkhoury
approved these changes
Apr 23, 2019
Contributor
jadelkhoury
left a comment
jadelkhoury
left a comment
There was a problem hiding this comment.
reviewed with Andrii. Looks good
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #21