Skip to content

Conversation

@colin-grant-work
Copy link
Contributor

What it does

Fixes #16852

Postpones logging of schema default registration warnings until all builtin preference contributions have been processed.

There could still be warnings about preferences that really do exist but that are expected to be registered by extensions and so are discovered after the registration of all builtin preferences.

How to test

  1. Add "preferences": {}, before this line
  2. Start the application.
  3. Observe that warnings are lot logged for workbench color theme, workbench icon theme, or any actually defined preference defined in your preferences object, but are logged for any non-existent preferences referred to by the preferences config in the Electron app's package.json.

Follow-ups

Breaking changes

  • This PR introduces breaking changes and requires careful review. If yes, the breaking changes section in the changelog has been updated.

Attribution

Review checklist

Reminder for reviewers

@github-project-automation github-project-automation bot moved this to Waiting on reviewers in PR Backlog Jan 20, 2026
@colin-grant-work colin-grant-work changed the title Postpone logging until builtin preferences registered Postpone default override warning logging until builtin preferences registered Jan 20, 2026
Copy link
Member

@ndoschek ndoschek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@github-project-automation github-project-automation bot moved this from Waiting on reviewers to Needs merge in PR Backlog Jan 22, 2026
@colin-grant-work colin-grant-work merged commit a5be115 into master Jan 22, 2026
10 checks passed
@colin-grant-work colin-grant-work deleted the bugfix/preference-schema-warnings branch January 22, 2026 17:44
@github-project-automation github-project-automation bot moved this from Needs merge to Done in PR Backlog Jan 22, 2026
@github-actions github-actions bot added this to the 1.68.0 milestone Jan 22, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

PreferenceShemaService: Warnings logged for expected behavior

3 participants