Postpone default override warning logging until builtin preferences registered #16853
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What it does
Fixes #16852
Postpones logging of schema default registration warnings until all builtin preference contributions have been processed.
There could still be warnings about preferences that really do exist but that are expected to be registered by extensions and so are discovered after the registration of all builtin preferences.
How to test
"preferences": {},before this linepreferencesobject, but are logged for any non-existent preferences referred to by thepreferencesconfig in the Electron app'spackage.json.Follow-ups
Breaking changes
Attribution
Review checklist
nlsservice (for details, please see the Internationalization/Localization section in the Coding Guidelines)Reminder for reviewers