Skip to content

Postpone default override warning logging until builtin preferences registered #16853

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
colin-grant-work merged 1 commit into from
Jan 22, 2026
Merged

Postpone default override warning logging until builtin preferences registered #16853

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 22 additions & 2 deletions packages/core/src/common/preferences/preference-schema-service.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,10 @@ export class PreferenceSchemaServiceImpl implements PreferenceSchemaService {
promises.push(contrib.initSchema(this));
}
});
Promise.all(promises).then(() => this._ready.resolve());
Promise.all(promises).then(() => {
this._ready.resolve();
this.logDefaultRegistrationWarnings();
});
}

dispose(): void {
Expand Down Expand Up @@ -128,6 +131,7 @@ export class PreferenceSchemaServiceImpl implements PreferenceSchemaService {
console.warn(`Property with id '${key}' already exists`);
continue;
}
this.pendingDefaultRegistrationWarnings?.delete(key);

if (property.scope === undefined) {
property.scope = schema.scope;
Expand Down Expand Up @@ -210,11 +214,27 @@ export class PreferenceSchemaServiceImpl implements PreferenceSchemaService {
}
}

protected pendingDefaultRegistrationWarnings: Set<string> | undefined = new Set();
protected logDefaultRegistrationWarnings(): void {
if (this.pendingDefaultRegistrationWarnings?.size) {
console.warn('Default overrides registered for these keys, but preferences not registered', Array.from(this.pendingDefaultRegistrationWarnings));
}
this.pendingDefaultRegistrationWarnings = undefined;
}

protected logDefaultRegistrationWarning(key: string): void {
if (this.pendingDefaultRegistrationWarnings) {
this.pendingDefaultRegistrationWarnings.add(key);
} else {
console.warn(`Trying to register default override for non-existent preference: ${key}`);
}
}

registerOverride(key: string, overrideIdentifier: string | undefined, value: JSONValue): Disposable {
const overrideId = overrideIdentifier || NO_OVERRIDE;
const property = this.properties.get(key);
if (!property) {
console.warn(`Trying to register default override for non-existent preference: ${key}`);
this.logDefaultRegistrationWarning(key);
} else if (!property.overridable && overrideIdentifier) {
console.warn(`Trying to register default override for identifier ${overrideIdentifier} for non-overridable preference: ${key}`);
}
Expand Down
Loading