Cu 21a0wgu - Update dependencies #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidmorley
reviewed
Jan 5, 2022
| @@ -1,4 +1,4 @@ | |||
| CONTAINER_NAME=nats-request-multi-js_request-multi_1 | |||
| CONTAINER_NAME=nats-multi-request-js-request-multi-1 | |||
There was a problem hiding this comment.
I'm not 100% sure what the naming conventions here would be, but if we're reversing the naming from request-multi to multi-request, shouldn't we do it in both parts of this name?
| @@ -1,22 +1,27 @@ | |||
| # nats-request-multi-js | |||
| # nats-multi-request-js | |||
There was a problem hiding this comment.
It strikes me that the name is a little misleading, since technically it's a single request that could have multiple responses. But I'm not sure what a better name would be.
| const natsError = { ...natsErrorBase, code: "err", name: "err", message: "test error" }; | ||
| try { | ||
| await testRequestMulti(3, 3, { natsError: natsError }); | ||
| await testRequestMulti(3, 3, ({ natsError })); |
There was a problem hiding this comment.
Hm, I'm not sure you need the parentheses here, but if it works it's not a big deal.
| const natsError = { ...natsErrorBase, code: "err", name: "err", message: "test error" }; | ||
| try { | ||
| await testRequestMulti(3, 2, { natsError: natsError }); | ||
| await testRequestMulti(3, 2, ({ natsError })); |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.