Skip to content

Cu 21a0wgu - Update dependencies #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
roguh wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Cu 21a0wgu - Update dependencies #2

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a173ccc
Fix linter warnings. Catch only relevant error, do not import unused …
roguh Jan 5, 2022
0bd0b6e
Update dependencies
roguh Jan 5, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
CONTAINER_NAME=nats-request-multi-js_request-multi_1
CONTAINER_NAME=nats-multi-request-js-request-multi-1
Copy link

@davidmorley davidmorley Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not 100% sure what the naming conventions here would be, but if we're reversing the naming from request-multi to multi-request, shouldn't we do it in both parts of this name?

setup:
npm install

Expand Down
13 changes: 9 additions & 4 deletions README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,22 +1,27 @@
# nats-request-multi-js
# nats-multi-request-js
Copy link

@davidmorley davidmorley Jan 5, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It strikes me that the name is a little misleading, since technically it's a single request that could have multiple responses. But I'm not sure what a better name would be.


Library for making NATS requests that receive multiple responses.

<!--
TODO: upload to npm
## Installation
```
npm i nats-request-multi
npm i nats-multi-request
OR
npm i -S nats-request-multi
npm i -S nats-multi-request
```
-->

## Usage

Returns as soon as `expected` responses arrive.

```
import { connect } from 'nats'
import requestMulti from 'nats-request-multi'
import requestMulti from 'nats-multi-request'
async () {
const nc = connect()
Expand Down
Loading