Fix entity generation #2548
Open
Fix entity generation #2548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Properly generate entity fields in all generated files. The top-level entity files were previously not being included in the generated files. This problem was partially hidden because the `make clean` command didn't remove generated files in `docs/reference/`, so some older entity files were kept. This updates the command to clean all generated files in `docs/reference`.
|
Documentation changes preview: https://docs-v3-preview.elastic.dev/elastic/ecs/pull/2548/reference/ |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
🔍 Preview links for changed docs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1. What does this PR do?
Correctly add entity to generated files.
entityfields were previously not being added to the generated files in all the correct places.This problem was partially hidden because the generated docs files weren't being removed with the
make cleancommand. This also fixes that problem.2. Which ECS fields are affected/introduced?
Top-level
entityfields are now added to the generated files.3. Why is this change necessary?
4. Have you added/updated documentation?
YES
5. Have you built ECS and committed any newly generated files?
YES
6. Have you run the ECS validation tests locally?
YES
7. Anything else for the reviewers?
Commit Message
Correctly add top-level
entityfields to the generated files.This also updates the
make cleancommand to clean generated doc files.