modify Windows GetAccessPaths to handle volumes that don't exist#190
Merged
leehinman merged 1 commit intoelastic:masterfrom Mar 18, 2026
Merged
Conversation
jsoriano
approved these changes
Mar 18, 2026
6 tasks
This was referenced Mar 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix Windows
GetAccessPathserror on non-existent volumesSummary
GetVolumePathsForVolumecan returnERROR_FILE_NOT_FOUNDfor volume names returned byGetVolumesthat no longer exist (e.g., ejected, transient or ghost volumes).GetVolumePathsForVolumecausedGetAccessPathsto return an error, making the entire call fail.ERROR_FILE_NOT_FOUNDas a non-fatal condition: the volume is silently skipped, consistent with how volumes with no mount paths are handled.Root Cause
The Windows
GetVolumesAPI can enumerate volume GUIDs for volumes that are registered but not currently present on the system. CallingGetVolumePathsForVolumeon such a volume returnsERROR_FILE_NOT_FOUND. This is an expected OS behavior, not a true error.Test Plan
GetAccessPathssucceeds on Windows when transient/ejected volumes are present