Skip to content

Conversation

@iammahmads
Copy link
Contributor

@iammahmads iammahmads commented May 6, 2025

Description of Change

I have seen that there is kept special care of using semantics in overall app. I think we should also use these semantics in out root.tsx file where the previous semantics were

<div>
        <header></header>
        <main></main>
        <footer></footer>
</div>

The new semantics remove the top-level div and the result is following while preserving the style present in top-level div by using that style inside main and footer i.e

<header></header>
<main></main>
<footer></footer>

Checklist

  • This PR was not created with AI. (PRs created mainly with AI will be closed. They waste our team's time. We ban repeat offenders.)

@iammahmads iammahmads requested review from a team as code owners May 6, 2025 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant