Skip to content

fix: semantics in root.tsx #174

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
iammahmads wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: semantics in root.tsx #174

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
136 changes: 68 additions & 68 deletions app/root.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,78 +56,78 @@ export function Layout({ children }: { children: React.ReactNode }) {
<Links />
</head>
<body>
<div className="min-h-screen bg-gradient-to-b from-gray-50 to-gray-100 dark:from-gray-900 dark:to-gray-950 flex flex-col">
<header className="sticky top-0 z-10 bg-white/90 dark:bg-[#2f3241]/90 backdrop-blur-md border-b border-gray-200 dark:border-[#9feaf9]/10">
<div className="container mx-auto px-4 py-4 flex items-center justify-between flex flex-col sm:flex-row gap-4">
<div className="flex items-center gap-2">
<Logo className="w-6 h-6 text-[#2f3241] dark:text-[#9feaf9]" />
<Link to="/" prefetch="intent">
<h1 className="text-xl font-semibold text-[#2f3241] dark:text-white">
Electron Releases
</h1>
</Link>
</div>
<nav className="flex items-center gap-6">
{nav.map((item) => (
<NavLink
key={item.path}
to={item.path}
target={item.path.startsWith('/') ? undefined : '_blank'}
rel={item.path.startsWith('/') ? undefined : 'noreferrer'}
className={({ isActive, isPending }) =>
`${
isActive || isPending
? 'text-[#2f3241] dark:text-[#9feaf9] hover:text-[#47496b] dark:hover:text-white'
: 'text-gray-600 dark:text-gray-300 hover:text-[#2f3241] dark:hover:text-white'
} transition-colors text-sm font-medium flex items-center gap-1`
}
prefetch={item.path.startsWith('/') ? 'intent' : undefined}
>
{item.title}
</NavLink>
))}
</nav>
<header className="sticky top-0 z-10 bg-white/90 dark:bg-[#2f3241]/90 backdrop-blur-md border-b border-gray-200 dark:border-[#9feaf9]/10">
<div className="container mx-auto px-4 py-4 flex items-center justify-between flex flex-col sm:flex-row gap-4">
<div className="flex items-center gap-2">
<Logo className="w-6 h-6 text-[#2f3241] dark:text-[#9feaf9]" />
<Link to="/" prefetch="intent">
<h1 className="text-xl font-semibold text-[#2f3241] dark:text-white">
Electron Releases
</h1>
</Link>
</div>
</header>
<nav className="flex items-center gap-6">
{nav.map((item) => (
<NavLink
key={item.path}
to={item.path}
target={item.path.startsWith('/') ? undefined : '_blank'}
rel={item.path.startsWith('/') ? undefined : 'noreferrer'}
className={({ isActive, isPending }) =>
`${
isActive || isPending
? 'text-[#2f3241] dark:text-[#9feaf9] hover:text-[#47496b] dark:hover:text-white'
: 'text-gray-600 dark:text-gray-300 hover:text-[#2f3241] dark:hover:text-white'
} transition-colors text-sm font-medium flex items-center gap-1`
}
prefetch={item.path.startsWith('/') ? 'intent' : undefined}
>
{item.title}
</NavLink>
))}
</nav>
</div>
</header>

<main className="container mx-auto px-4 py-12 flex-1">{children}</main>
<main className=" mx-auto px-4 py-12 flex-1 bg-gradient-to-b from-gray-50 to-gray-100 dark:from-gray-900 dark:to-gray-950">
{children}
</main>

<footer className="container mx-auto px-4 py-8 mt-4 border-t border-gray-200 dark:border-gray-800">
<div className="max-w-4xl mx-auto flex flex-col md:flex-row items-center justify-between gap-4">
<div className="flex items-center gap-2">
<span className="text-sm text-gray-500 dark:text-gray-400">
Provided with ❤️ by Electron
</span>
</div>
<div className="flex items-center gap-6">
<Link
to="https://github.com/electron/electron"
target="_blank"
rel="noreferrer"
className="text-gray-500 hover:text-[#2f3241] dark:text-gray-400 dark:hover:text-white transition-colors text-sm"
>
GitHub
</Link>
<Link
to="https://electronjs.org"
target="_blank"
rel="noreferrer"
className="text-gray-500 hover:text-[#2f3241] dark:text-gray-400 dark:hover:text-white transition-colors text-sm"
>
Website
</Link>
<Link
to="https://bsky.app/profile/electronjs.org"
target="_blank"
rel="noreferrer"
className="text-gray-500 hover:text-[#2f3241] dark:text-gray-400 dark:hover:text-white transition-colors text-sm"
>
Bluesky
</Link>
</div>
<footer className="mx-auto px-4 py-8 border-t border-gray-200 dark:border-gray-800 bg-gradient-to-b from-gray-50 to-gray-100 dark:from-gray-900 dark:to-gray-950">
<div className="max-w-4xl mx-auto flex flex-col md:flex-row items-center justify-between gap-4">
<div className="flex items-center gap-2">
<span className="text-sm text-gray-500 dark:text-gray-400">
Provided with ❤️ by Electron
</span>
</div>
<div className="flex items-center gap-6">
<Link
to="https://github.com/electron/electron"
target="_blank"
rel="noreferrer"
className="text-gray-500 hover:text-[#2f3241] dark:text-gray-400 dark:hover:text-white transition-colors text-sm"
>
GitHub
</Link>
<Link
to="https://electronjs.org"
target="_blank"
rel="noreferrer"
className="text-gray-500 hover:text-[#2f3241] dark:text-gray-400 dark:hover:text-white transition-colors text-sm"
>
Website
</Link>
<Link
to="https://bsky.app/profile/electronjs.org"
target="_blank"
rel="noreferrer"
className="text-gray-500 hover:text-[#2f3241] dark:text-gray-400 dark:hover:text-white transition-colors text-sm"
>
Bluesky
</Link>
</div>
</footer>
</div>
</div>
</footer>
<ScrollRestoration />
<Scripts />
</body>
Expand Down