Skip to content

Conversation

@pixlwave
Copy link
Member

@pixlwave pixlwave commented Jan 6, 2026

The tests have been failing as Xcode now removes Text("").accessibilityIdentifier(someID) from the hierarchy but we are asserting app.staticTexts[someID].exists. This PR simply makes sure there's some non-empty values.

The test were failing as Xcode now removes Text("").accessibilityIdentifier(someID) from the hierarchy but we were asserting that they existed.
@pixlwave pixlwave mentioned this pull request Jan 6, 2026
8 tasks
@codecov
Copy link

codecov bot commented Jan 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 16.59%. Comparing base (ede2db6) to head (442a26d).
⚠️ Report is 5 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #7994      +/-   ##
===========================================
- Coverage    16.96%   16.59%   -0.38%     
===========================================
  Files         1766     1813      +47     
  Lines       122112   119370    -2742     
  Branches     49184    47775    -1409     
===========================================
- Hits         20719    19807     -912     
+ Misses      100717    98893    -1824     
+ Partials       676      670       -6     
Flag Coverage Δ
uitests 59.70% <100.00%> (+3.98%) ⬆️
unittests 8.82% <0.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pixlwave pixlwave merged commit 675f312 into develop Jan 6, 2026
7 checks passed
@pixlwave pixlwave deleted the doug/fix-ui-tests branch January 6, 2026 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants