Replace FileChooserButton for GTK4#243
Merged
danirabbit merged 14 commits intomasterfrom Aug 29, 2023
Merged
Conversation
Collaborator
|
Maybe should stick to the FileChooserNative API as this is now Flatpak'd? |
Member
Author
|
Right! I agree. Thanks @jeremypw |
Collaborator
|
The drop arrows on the two buttons are of a different size, furthermore the filechooser button does not produce a dropdown when clicked, but a dialog so I think it should have an ellipsis? |
Collaborator
|
This is how it looks after applying my suggestions (I also increased the icon size to 24px but that is not essential). |
jeremypw
previously requested changes
May 31, 2022
Member
Author
|
@jeremypw is there an icon we can use for ellipsis? Thank you. |
Member
Author
|
oh I found it! it is |
Member
Author
|
it does not seem aligned still. |
Collaborator
|
Probably best seek @danrabbit 's opinion on the finer points of the design. |
added 3 commits
February 1, 2023 18:45
# Conflicts: # src/Widgets/SaveDialog.vala
Collaborator
|
Still being held up by the existence of #253. |
danirabbit
approved these changes
Aug 29, 2023
Member
danirabbit
left a comment
danirabbit
left a comment
There was a problem hiding this comment.
Works as expected, nice job!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This hopes to check a todo in #240 so screenshot can be ported.