fix: update PR status selector from button to link#653
Open
empiricalrun[bot] wants to merge 1 commit intomainfrom
Open
fix: update PR status selector from button to link#653empiricalrun[bot] wants to merge 1 commit intomainfrom
empiricalrun[bot] wants to merge 1 commit intomainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the failing test "create session, send message, detect branch, create PR, and verify PR status in UI" in
tests/github-pr-status.spec.ts.Problem
The test was failing at line 110 because it was looking for the PR status as a button element:
However, the UI displays the PR status as a link:
Fix
Updated line 110 to use the correct selector:
Changes made:
getByRole('button')→getByRole('link')to match the actual element type/^PR #\d+$/→/PR #\d+ opened/to match the actual text contentTest Results
✅ Test passes after the fix
Report URL: https://reports-r2.empirical.run/test-gen-chat-agent/1769074167948/index.html
References
PR created from session #72288
Updated at 2026-01-22 09:30:48.248 UTC