Skip to content

fix: update PR status selector from button to link#653

Open
empiricalrun[bot] wants to merge 1 commit intomainfrom
chat-session_69Pk0YtEwUVv
Open

fix: update PR status selector from button to link#653
empiricalrun[bot] wants to merge 1 commit intomainfrom
chat-session_69Pk0YtEwUVv

Conversation

@empiricalrun
Copy link
Copy Markdown
Contributor

@empiricalrun empiricalrun Bot commented Jan 22, 2026

Summary

Fixes the failing test "create session, send message, detect branch, create PR, and verify PR status in UI" in tests/github-pr-status.spec.ts.

Problem

The test was failing at line 110 because it was looking for the PR status as a button element:

await expect(page.getByRole('button', { name: /^PR #\d+$/ })).toBeVisible({ timeout: 25000 });

However, the UI displays the PR status as a link:

- link "PR #17624 opened":
  - /url: https://github.com/empirical-run/lorem-ipsum-tests/pull/17624
  - text: "PR #17624 opened"

Fix

Updated line 110 to use the correct selector:

await expect(page.getByRole('link', { name: /PR #\d+ opened/ })).toBeVisible({ timeout: 25000 });

Changes made:

  1. Changed getByRole('button')getByRole('link') to match the actual element type
  2. Updated regex from /^PR #\d+$//PR #\d+ opened/ to match the actual text content

Test Results

✅ Test passes after the fix

Report URL: https://reports-r2.empirical.run/test-gen-chat-agent/1769074167948/index.html

References

  • Failed Run: #45769 (Jan 22, 09:13 UTC)
  • Diagnosis ID: IX8fhOUKcgTM
  • Last Successful Run: #45745 (Jan 22, 08:00 UTC)

PR created from session #72288

Updated at 2026-01-22 09:30:48.248 UTC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants