Skip to content

fix: update PR status selector from button to link #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
empiricalrun wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: update PR status selector from button to link #653

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions tests/github-pr-status.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -104,10 +104,10 @@ test.describe('GitHub PR Status Tests', () => {
expect(prData.title).toContain(headBranch);
expect(prData.state).toBe('open');

// Step 5: Wait for the PR status to be automatically updated and verify it shows the PR button
// Step 5: Wait for the PR status to be automatically updated and verify it shows the PR link
// The PR status is now updated automatically, no refresh button needed
// Wait up to 25 seconds for the PR button to appear with the new format "PR #<number>"
await expect(page.getByRole('button', { name: /^PR #\d+$/ })).toBeVisible({ timeout: 25000 });
// Wait up to 25 seconds for the PR link to appear with the format "PR #<number> opened"
await expect(page.getByRole('link', { name: /PR #\d+ opened/ })).toBeVisible({ timeout: 25000 });

// Step 6: Close the PR via UI
// Click on Review
Expand Down